Classes summary
| cGuiFileOverview |
This feature does not work at the moment. <strong>Template</strong>
This class is bound to the template generic_file_overview in a hardcoded manner
(template,generic_file_overview.html). |
This prevents this class to be used with other views. <strong>Editing a
file</strong> When editing a file
- the right top frame is opened with the URL: main.php ?area={AREA}
&frame=3 &file={FILENAME} &contenido=1
- whereas the right bottom frame is opened with the URL: main.php ?area={AREA}
&frame=4 &action={ACTION} &file={FILENAME} &tmp_file={FILENAME}
&contenido=1
AREA & ACTION are filled with the current global values. FILENAME is the
name of the current file. |
| Why the parameter contenido is set to 1 is to be clarified. IMHO it should be
the current value of the global contenido variable. |
Why the parameter file and tmp_file are both set is to be clarified.
<strong>Deleting a file</strong> A delete icon is provided for each
file. When deleting a file
- the right bottom frame is opened with the URL: main.php ?area={AREA}
&action={ACTION} &frame=4 &delfile={FILENAME}
|
| Why the parameter contenido is not set is to be clarified. |
| Why the URL is generated via JS is to be clarified. If the effective setting
client/readonly is "true" or the current user has no privileges for the action
$area . "_delete" of the current area this icon will be inactive though. |
| This prevents this class to be used in other areas. |
| cHTMLAlphaImage |
Remove the usage of this class. We dont need special alpha filter for IE
anymore. The last place where it is still in use are the error lists with
content toggle (+ - icons) feature! |
| cHTMLScript |
Should set attribute type="text/javascript" by default or depending on doctype! |
| cMailer |
explain logging of mails via _logMail() <strong>Resending
mails</strong> |
| explain resending of mails via resendMail() <strong>Sending user created
messages</strong> Creating your own message is e.g. necessary in order to
send mails with attachments as the simplified interface the cMailer class offers
does not yet provide means to do so. |
| explain sending of user created messages via send() <strong>Default
transport</strong> By default the cMailer tries to use an SMTP transport
with optional authentication. If starting the SMTP transport fails, a simple
MAIL transport will be used (using PHP's mail() function). <strong>User
defined transport</strong> When creating a cMailer instance an arbitrary
transport can be given to override the afore mentioned behaviour.
<strong>User defined transport example</strong> <code> |
| add example </code> <strong>User defined character
set</strong> |
| explain setCharset() |
| cUriBuilderMR |
add handling of absolute paths |
| standardize handling of fragments |
Methods summary
| cAjaxRequest |
handle() |
split functionality into seperate methods |
| use registry instead of globals where possible |
| cApiCecHook |
_debug() |
Implement cec_hook debug mode for automatic logging when activated. Writes the
debug value into a logfile (see contenido/data/log/cec_hook_debug.log). |
| cApiClient |
getInstance() |
There is no need since caching is available at GenericDB level |
| cApiClient |
getProperties() |
return value should be the same as getPropertiesByType(), e.g. an empty array
instead of false |
| cApiClient |
setProperty() |
should return return value as overwritten method |
| cApiClientLanguage |
deleteProperty() |
Use parents method @see Item::deleteProperty(), but be carefull, different
parameter! |
| cApiClientLanguage |
getProperties() |
return value should be the same as getPropertiesByType(), e.g. an empty array
instead of false |
| cApiClientLanguage |
getProperty() |
Use parents method @see Item::getProperty() |
| cApiClientLanguage |
setProperty() |
Use parents method |
| should return return value as overwritten method |
| cApiFileInformationCollection |
create() |
Pass additional fields as optional parameters |
| cApiFileInformationCollection |
updateFile() |
Pass additional fields as optional parameters |
| cApiFrontendGroupMemberCollection |
create() |
Should return null in case of failure |
| cApiKeywordCollection |
create() |
params w/ defaults should be relocated |
| cApiRightCollection |
deleteByUserId() |
Implement functions to delete rights by area, action, cat, client, language. |
| cApiUploadCollection |
delete() |
Code is similar/redundant to include.upl_files_overview.php 216-230 |
| cApiUser |
getUserPropertiesByType() |
return value should be similar to getUserProperties() |
| cApiUser |
setValidDateFrom() |
add type checks |
| cApiUser |
setValidDateTo() |
add type check |
| cArray |
searchRecursive() |
There should be only one flag for $partial and $strict in order to avoid
ambiguities (imagine $partial=true & $strict=true). |
| cAuthHandlerAbstract |
preAuthorize() |
should be named preAuth or preAuthenticate |
| cCodeGeneratorAbstract |
_processNoConfigurationError() |
This method is not required as it is only used in the standard code generator. |
| cCodeGeneratorAbstract |
getArtLangObject() |
deprecate me |
| cContentTypeFilelist |
getConfiguredFiles() |
unify return values |
| cContentVersioning |
getContentId() |
check datatype of return value |
| cContentVersioning |
getSelectedArticle() |
$idArtlangVersion <-> $selectedArticleId |
| cDbDriverMysqli |
free() |
check if $this should be returned |
| cGuiTableForm |
addHeader() |
rename addHeader() to setHeader() |
| cItemCache |
addItem() |
check if null should be returned |
| cItemCache |
removeItem() |
check if null should be returned |
| cItemCache |
removeItems() |
check if null should be returned |
| cMailer |
__construct() |
add type hinting! |
| cMailer |
constructTransport() |
making this a static method and passing all the params is not that smart! |
| cMailer |
decodeField() |
check why conHtmlEntityDecode() is called w/ 4 params |
| cMailer |
encodeField() |
check why conHtmlEntities() is called w/ 4 params |
| cRegistry |
getDb() |
perhaps its better to instantiate only one object and reset it on call |
| cSearch |
getSubTree() |
This is not the job for search, should be outsourced ... |
| cSearchResult |
getArtCat() |
refactor this because it shouldn't be the Search's job |
| cString |
recodeString() |
Check if the charset names are the same for both converters |
| Implement a converter and charset checker to ensure compilance. |
| cTree |
__construct() |
The root item currently has to be a "0". This is a bug, feel free to fix it. |
| cUpdateNotifier |
fetchUrl() |
add a retry counter and a deathpoint with warning in errorlog |
| cUriBuilderCustomPath |
buildUrl() |
Somehow get around using prCreateURLNameLocationString() |
| Item |
_inFilter() |
This method is used from public scope, but it should be protected |
| PifaField |
_getElemField() |
should be private, right? |
| PifaField |
_getElemHelp() |
should be private, right? |
| PifaField |
_getElemLabel() |
should be private, right? |
| PifaField |
_getElemScript() |
should be private, right? |
| PifaForm |
store() |
Check if method store() should be implemented for PifaField too. |
Functions summary
buildUserOrGroupPermsFromRequest |
Do we really need to add other perms, if the user/group gets the 'sysadmin'
permission? |
cApiStrRecodeString |
Check if the charset names are the same for both converters |
| Implement a converter and charset checker to ensure compilance. |
conGetTopmostCat |
Returns something.... |
modDeleteModule |
some global vars seem to be overfluous |
mr_strMovedownCategory |
do we really need processing of the category? there is no mr relevant data
changes while moving the category on same level, level and name won't change |
mr_strMoveUpCategory |
do we really need processing of the category? there is no mr relevant data
changes while moving the category on same level, level and name won't change |
saveSitemap |
How can I save this properly formatted? |
strSortPrePost |
Check logic, move sorting to db layer, if possible! |
tplAutoFillModules |
The default module is only inserted in mandatory mode if the container is empty.
We need a better logic for handling "changes". |
uplHasFiles |
Function name is misleading, should be renamed to uplIsEmpty |